Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb_query_datatype,collation: remove utf8mb4_0900_bin from need_restored_data #15572

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Sep 12, 2023

What is changed and how it works?

Issue Number: Close #15571

What's Changed:

  1. The collation utf8mb4_0900_bin is excluded from need_restored_data.
  2. Fix the is_bin_collation for utf8mb4_0900_bin.

Ref pingcap/tidb#46781

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

This bug doesn't have a release note, because it's a new feature in #15398 and haven't been released

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • breezewish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed do-not-merge/release-note-label-needed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2023
@YangKeao
Copy link
Member Author

/cc @sticnarf @breezewish @andylokandy

@YangKeao
Copy link
Member Author

/retest

@YangKeao
Copy link
Member Author

/run-test

@YangKeao
Copy link
Member Author

/cc @zimulala @CbcWestwolf

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 13, 2023

@YangKeao: GitHub didn't allow me to request PR reviews from the following users: CbcWestwolf, zimulala.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @zimulala @CbcWestwolf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 13, 2023
@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 13, 2023

@breezewish: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 13, 2023

This pull request has been accepted and is ready to merge.

Commit hash: f983ddf

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 13, 2023
@YangKeao
Copy link
Member Author

/release-note-none

@ti-chi-bot ti-chi-bot bot merged commit b75f559 into tikv:master Sep 13, 2023
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utf8mb4_0900_bin shouldn't try to read RestoredData
3 participants