Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[backup apiv2] fix file range in backup response" #12570

Merged
merged 2 commits into from
May 19, 2022
Merged

Revert "[backup apiv2] fix file range in backup response" #12570

merged 2 commits into from
May 19, 2022

Conversation

haojinming
Copy link
Contributor

@haojinming haojinming commented May 18, 2022 •
edited
Loading

Signed-off-by: haojinming [email protected]

What is changed and how it works?

Issue Number: Close #12571

What's Changed:

revert #12550
It's better to handle file range encoding in tikv-br tools. File range should keep user key not encoded key and keep same logic with non-raw kv backup.

Related changes

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

  • No side effect

Release note 

rawkv apiv2 backup bug fix

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2022
@haojinming haojinming force-pushed the revert-12550-fix_raw_backup_file_range branch from fa9730a to 46e2622 Compare May 18, 2022 14:32
@haojinming haojinming mentioned this pull request May 18, 2022
Closed
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 18, 2022
@haojinming
Copy link
Contributor Author

/cc @3pointer @overvenus PTAL~ thanks.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2022
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 46e2622

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2022
@ti-chi-bot
Copy link
Member

@haojinming: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@iosmanthus
Copy link
Member

LGTM

@iosmanthus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@iosmanthus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@haojinming
Copy link
Contributor Author

/run-test

@haojinming
Copy link
Contributor Author

/run-build

@haojinming
Copy link
Contributor Author

/run-test

@haojinming
Copy link
Contributor Author

/run-test

1 similar comment
@haojinming
Copy link
Contributor Author

/run-test

@ti-chi-bot ti-chi-bot merged commit 8c02d7b into tikv:master May 19, 2022
fengou1 pushed a commit to fengou1/tikv that referenced this pull request May 26, 2022
@haojinming @ti-chi-bot @fengou1
Revert "[backup apiv2] fix file range in backup response" (tikv#12570)
a08dca5 
ref tikv#12550, close tikv#12571

Signed-off-by: haojinming <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@overvenus overvenus overvenus approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert "[backup apiv2] fix file range in backup response" #12570
5 participants
@haojinming @ti-chi-bot @overvenus @iosmanthus @3pointer