Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log-backup: support encrypting the temporary files #15083

Closed
YuJuncen opened this issue Jul 6, 2023 · 2 comments · Fixed by #16993
Closed

log-backup: support encrypting the temporary files #15083

YuJuncen opened this issue Jul 6, 2023 · 2 comments · Fixed by #16993
Labels
affects-8.1 component/backup-restore Component: backup, import, external_storage severity/major type/enhancement Type: Issue - Enhancement

Comments

@YuJuncen
Copy link
Contributor

YuJuncen commented Jul 6, 2023

Development Task

As title, for now, temporary files are plain text. Which isn't good enough and may be leaked when TiKV exits unexpectedly.
@YuJuncen YuJuncen added the type/enhancement Type: Issue - Enhancement label Jul 6, 2023
@YuJuncen YuJuncen mentioned this issue Jul 6, 2023
Merged
@BornChanger
Copy link
Contributor

/component backup-restore

@ti-chi-bot ti-chi-bot bot added the component/backup-restore Component: backup, import, external_storage label Jan 24, 2024
@BornChanger
Copy link
Contributor

/severity major

ti-chi-bot bot added a commit that referenced this issue May 7, 2024
@YuJuncen @ti-chi-bot
log-backup: support encrypt backing up files (#15084)
608fc17 
ref #15083

Signed-off-by: Yu Juncen <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@YuJuncen YuJuncen mentioned this issue May 10, 2024
Merged
9 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 87f6643 Jun 24, 2024
3AceShowHand pushed a commit to 3AceShowHand/tikv that referenced this issue Jun 27, 2024
@YuJuncen @ti-chi-bot @3AceShowHand
log_backup: Adapt for log backup encrypting (tikv#16993)
ca9af84 
close tikv#15083

Allows log backup to read the encryption config and use it to encrypt the local files.

Signed-off-by: hillium <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: 3AceShowHand <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Jul 29, 2024
@YuJuncen @ti-chi-bot @ti-chi-bot
log-backup: support encrypt backing up files (tikv#15084)
9434009 
ref tikv#15083

Signed-off-by: Yu Juncen <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this issue Jul 29, 2024
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Jul 29, 2024
@YuJuncen @ti-chi-bot
This is an automated cherry-pick of tikv#16993
becbc5e 
close tikv#15083

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Jul 29, 2024
Merged
9 tasks
YuJuncen added a commit to ti-chi-bot/tikv that referenced this issue Aug 2, 2024
@YuJuncen @ti-chi-bot
log-backup: support encrypt backing up files (tikv#15084)
f063b0f 
ref tikv#15083

Signed-off-by: Yu Juncen <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: hillium <[email protected]>
ti-chi-bot bot added a commit that referenced this issue Aug 2, 2024
@ti-chi-bot @YuJuncen @ti-chi-bot
log-backup: support encrypt backing up files (#15084) (#17322)
18fc036 
ref #15083

Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: hillium <[email protected]>

Co-authored-by: 山岚 <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
YuJuncen added a commit to ti-chi-bot/tikv that referenced this issue Aug 2, 2024
@YuJuncen @ti-chi-bot
log_backup: Adapt for log backup encrypting (tikv#16993)
d74f452 
close tikv#15083

Allows log backup to read the encryption config and use it to encrypt the local files.

Signed-off-by: hillium <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
YuJuncen added a commit to ti-chi-bot/tikv that referenced this issue Aug 2, 2024
@YuJuncen @ti-chi-bot
log_backup: Adapt for log backup encrypting (tikv#16993)
89a016f 
close tikv#15083

Allows log backup to read the encryption config and use it to encrypt the local files.

Signed-off-by: hillium <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: hillium <[email protected]>
ti-chi-bot bot pushed a commit that referenced this issue Aug 2, 2024
@ti-chi-bot @YuJuncen
log_backup: Adapt for log backup encrypting (#16993) (#17323)
31b5c9f 
close #15083

Allows log backup to read the encryption config and use it to encrypt the local files.

Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>

Co-authored-by: 山岚 <[email protected]>
RidRisR pushed a commit to RidRisR/tikv that referenced this issue Aug 5, 2024
@ti-chi-bot @YuJuncen
@ti-chi-bot @RidRisR
log-backup: support encrypt backing up files (tikv#15084) (tikv#17322)
68b2685 
ref tikv#15083

Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: hillium <[email protected]>

Co-authored-by: 山岚 <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: RidRisR <[email protected]>
RidRisR pushed a commit to RidRisR/tikv that referenced this issue Aug 5, 2024
@ti-chi-bot @YuJuncen @RidRisR
log_backup: Adapt for log backup encrypting (tikv#16993) (tikv#17323)
ba9ccb3 
close tikv#15083

Allows log backup to read the encryption config and use it to encrypt the local files.

Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>

Co-authored-by: 山岚 <[email protected]>
Signed-off-by: RidRisR <[email protected]>
RidRisR pushed a commit to RidRisR/tikv that referenced this issue Aug 5, 2024
@ti-chi-bot @YuJuncen
@ti-chi-bot @RidRisR
log-backup: support encrypt backing up files (tikv#15084) (tikv#17322)
7a37fc5 
ref tikv#15083

Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: hillium <[email protected]>

Co-authored-by: 山岚 <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: RidRisR <[email protected]>
RidRisR pushed a commit to RidRisR/tikv that referenced this issue Aug 5, 2024
@ti-chi-bot @YuJuncen @RidRisR
log_backup: Adapt for log backup encrypting (tikv#16993) (tikv#17323)
253659f 
close tikv#15083

Allows log backup to read the encryption config and use it to encrypt the local files.

Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>

Co-authored-by: 山岚 <[email protected]>
Signed-off-by: RidRisR <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-8.1 component/backup-restore Component: backup, import, external_storage severity/major type/enhancement Type: Issue - Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

log_backup: Adapt for log backup encrypting YuJuncen/tikv
3 participants
@YuJuncen @ti-chi-bot @BornChanger