Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add batch split #6

Merged
merged 15 commits into from
Dec 20, 2018
Merged

Add batch split #6

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
27080ea
Add batch split
Connor1996 Oct 25, 2018
49f184a
some change
Connor1996 Oct 25, 2018
ac7096d
address comment
Connor1996 Oct 25, 2018
8e6e698
address comment
Connor1996 Oct 30, 2018
300f8b3
address comment
Connor1996 Nov 2, 2018
918d432
address comment
Connor1996 Nov 23, 2018
b31552c
Merge branch 'master' into Connor1996-patch-1
Connor1996 Nov 26, 2018
095d561
address comment
Connor1996 Nov 26, 2018
84a7a16
format
Connor1996 Nov 26, 2018
d9fa785
adjust format
Connor1996 Nov 28, 2018
4529dda
fix grammar
Connor1996 Nov 28, 2018
c193676
simplify
Connor1996 Nov 28, 2018
fbd7230
Merge branch 'master' into Connor1996-patch-1
huachaohuang Dec 5, 2018
872f84a
Merge branch 'master' into Connor1996-patch-1
Hoverbear Dec 20, 2018
dec91b9
Fix lints
Hoverbear Dec 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adjust format 
Signed-off-by: Connor1996 <[email protected]>
  • Loading branch information
@Connor1996
Connor1996 committed Nov 28, 2018
commit d9fa78533a96b0a058421e2e45a6e3469d759927
12 changes: 4 additions & 8 deletions text/2018-10-25-batch-split.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ service PD {
option deprecated = true;
}
rpc AskBatchSplit(AskBatchSplitRequest) returns (AskBatchSplitResponse) {}
rpc ReportBatchSplit(ReportBatchSplitRequest)
returns (ReportBatchSplitResponse) {}
rpc ReportBatchSplit(ReportBatchSplitRequest) returns (ReportBatchSplitResponse) {}
}

message AskBatchSplitRequest {
Expand Down Expand Up @@ -83,8 +82,7 @@ deprecated.
```protobuf
message SplitRequest {
// ...
// Will be ignored in batch split. Use `BatchSplitRequest::right_derive`
// instead.
// Will be ignored in batch split. Use `BatchSplitRequest::right_derive` instead.
bool right_derive = 4 [deprecated=true];
}

Expand Down Expand Up @@ -143,10 +141,8 @@ pub trait SplitChecker {
// before: fn split_key(&mut self) -> Option<Vec<u8>>
fn split_keys(&mut self) -> Vec<Vec<u8>>;

// before: fn approximate_split_key(&self, _: &Region, _: &DB)
// -> Result<Option<Vec<u8>>>
fn approximate_split_keys(&self, _: &Region, _: &DB) ->
Result<Vec<Vec<u8>>> {
// before: fn approximate_split_key(&self, _: &Region, _: &DB) -> Result<Option<Vec<u8>>>
fn approximate_split_keys(&self, _: &Region, _: &DB) -> Result<Vec<Vec<u8>>>;
}
```

Expand Down