Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local reader #17

Merged
merged 13 commits into from
May 31, 2021
Merged

Local reader #17

merged 13 commits into from
May 31, 2021

Conversation

overvenus
Copy link
Member

The RFC of Local Reader.

Signed-off-by: Neil Shen [email protected]

@overvenus
Local reader
cfd6d3a 
Signed-off-by: Neil Shen <[email protected]>
@overvenus
clarify ambiguous
e489569 
Signed-off-by: Neil Shen <[email protected]>
lilin90
lilin90 reviewed Nov 28, 2018
View reviewed changes
text/2018-01-03-local-reader.md Outdated Show resolved Hide resolved
text/2018-01-03-local-reader.md Outdated Show resolved Hide resolved
@overvenus
Address comments
3deaab9 
Signed-off-by: Neil Shen <[email protected]>
lilin90
lilin90 reviewed Nov 29, 2018
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hoverbear Hoverbear added the Initial Comment Period This RFC is in the initial comment period, and has quite some time to give input on. label Dec 20, 2018
Hoverbear
Hoverbear approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@Hoverbear Hoverbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

text/2018-01-03-local-reader.md Outdated Show resolved Hide resolved
text/2018-01-03-local-reader.md Outdated Show resolved Hide resolved
text/2018-01-03-local-reader.md Outdated Show resolved Hide resolved
Hoverbear
Hoverbear reviewed Feb 26, 2019
View reviewed changes
text/2018-01-03-local-reader.md Outdated Show resolved Hide resolved
text/2018-01-03-local-reader.md Outdated Show resolved Hide resolved
text/2018-01-03-local-reader.md Outdated Show resolved Hide resolved
@overvenus
Address comments
c717ef8 
Signed-off-by: Neil Shen <[email protected]>
@Hoverbear
Copy link
Contributor

@lilin90 Please give an approval again. :)

@Hoverbear Hoverbear added Final Comment Period This RFC is in the final comment period, and has a limited amount of time to give input on. and removed Initial Comment Period This RFC is in the initial comment period, and has quite some time to give input on. labels Mar 6, 2019
zhangjinpeng87
zhangjinpeng87 approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BusyJay BusyJay merged commit c95985e into master May 31, 2021
@BusyJay BusyJay deleted the localreader branch May 31, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 left review comments

@Hoverbear Hoverbear Hoverbear approved these changes

@zhangjinpeng87 zhangjinpeng87 zhangjinpeng87 approved these changes

@BusyJay BusyJay BusyJay approved these changes

@siddontang siddontang Awaiting requested review from siddontang

Assignees

@overvenus overvenus

Labels
Final Comment Period This RFC is in the final comment period, and has a limited amount of time to give input on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@overvenus @Hoverbear @BusyJay @zhangjinpeng87 @lilin90