-
Notifications
You must be signed in to change notification settings - Fork 67
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into Connor1996-patch-1
- Loading branch information
Showing
10 changed files
with
347 additions
and
201 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
node_modules/ | ||
package-lock.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"default": true, | ||
"MD013": { | ||
"code_blocks": false | ||
}, | ||
"MD034": false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
language: node_js | ||
node_js: | ||
- 10 | ||
cache: npm | ||
script: | ||
- npm run lint |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,47 @@ | ||
# TiKV RFCs | ||
|
||
Many changes, including bug fixes and documentation improvements can be implemented and reviewed via the normal GitHub pull request workflow. | ||
Many changes, including bug fixes and documentation improvements can be | ||
implemented and reviewed via the normal GitHub pull request workflow. | ||
|
||
Some changes though are "substantial", and we ask that these be put through a bit of a design process and produce a consensus among the TiKV community. | ||
Some changes though are "substantial", and we ask that these be put through a | ||
bit of a design process and produce a consensus among the TiKV community. | ||
|
||
The "RFC" (request for comments) process is intended to provide a consistent and controlled path for new features to enter the project, so that all stakeholders can be confident about the direction the project is evolving in. | ||
The "RFC" (request for comments) process is intended to provide a consistent | ||
and controlled path for new features to enter the project, so that all | ||
stakeholders can be confident about the direction the project is evolving in. | ||
|
||
### How to submit an RFC | ||
## How to submit an RFC | ||
|
||
1. Copy `template.md` into `text/YYYY-MM-DD-my-feature.md`. | ||
2. Write the document and fill in the blanks. | ||
3. Submit a pull request. | ||
|
||
### Timeline of an RFC | ||
## Timeline of an RFC | ||
|
||
1. An RFC is submitted as a PR. | ||
2. Discussion takes place, and the text is revised in response. | ||
3. The PR is merged or closed when at least two project maintainers reach consensus. | ||
3. The PR is merged or closed when at least two project maintainers reach | ||
consensus. | ||
|
||
### License | ||
## Style of an RFC | ||
|
||
This content is licensed under Apachie License, Version 2.0, ([LICENSE](LICENSE) or | ||
http:https://www.apache.org/licenses/LICENSE-2.0) | ||
We follow lint rules listed in | ||
[markdownlint](https:https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md). | ||
|
||
### Contributions | ||
Run lints (you must have [Node.js](https://nodejs.org) installed): | ||
|
||
Unless you explicitly state otherwise, any contribution intentionally submitted for inclusion in the work by you, as defined in the Apache-2.0 license, shall be dual licensed as above, without any additional terms or conditions. | ||
```bash | ||
# Install linters: npm install | ||
npm run lint | ||
``` | ||
|
||
## License | ||
|
||
This content is licensed under Apachie License, Version 2.0, | ||
([LICENSE](LICENSE) or http:https://www.apache.org/licenses/LICENSE-2.0) | ||
|
||
## Contributions | ||
|
||
Unless you explicitly state otherwise, any contribution intentionally submitted | ||
for inclusion in the work by you, as defined in the Apache-2.0 license, shall | ||
be dual licensed as above, without any additional terms or conditions. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"name": "rfcs", | ||
"version": "0.0.0", | ||
"devDependencies": { | ||
"markdownlint-cli": "^0.13.0" | ||
}, | ||
"scripts": { | ||
"lint": "markdownlint text/*.md" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,33 @@ | ||
# Summary | ||
# Title | ||
|
||
## Summary | ||
|
||
One para explanation of the proposal. | ||
|
||
# Motivation | ||
## Motivation | ||
|
||
Why are we doing this? What use cases does it support? What is the expected outcome? | ||
Why are we doing this? What use cases does it support? What is the expected | ||
outcome? | ||
|
||
# Detailed design | ||
## Detailed design | ||
|
||
This is the bulk of the RFC. Explain the design in enough detail that: | ||
|
||
- It is reasonably clear how the feature would be implemented. | ||
- Corner cases are dissected by example. | ||
- How the feature is used. | ||
|
||
# Drawbacks | ||
## Drawbacks | ||
|
||
Why should we not do this? | ||
|
||
# Alternatives | ||
## Alternatives | ||
|
||
- Why is this design the best in the space of possible designs? | ||
- What other designs have been considered and what is the rationale for not choosing them? | ||
- What other designs have been considered and what is the rationale for not | ||
choosing them? | ||
- What is the impact of not doing this? | ||
|
||
# Unresolved questions | ||
## Unresolved questions | ||
|
||
What parts of the design are still to be determined? | ||
What parts of the design are still to be determined? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.