Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use web_time for SystemTime::now to support WASM runtimes #34

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Use web_time for SystemTime::now to support WASM runtimes #34

merged 1 commit into from
Jan 24, 2024

Conversation

dotansimha
Copy link
Contributor

No need for any conditional configuration, as it's already done in web-time:

At the same time the library will simply re-export std::time when not using the wasm32-unknown-unknown target and will not pull in any dependencies.

@dotansimha
Copy link
Contributor Author

dotansimha commented Jan 24, 2024 •
edited
Loading

@zhongzc @andylokandy tested on an actual project and it seems to work great 🎉

@dotansimha dotansimha mentioned this pull request Jan 24, 2024
Closed
@dotansimha dotansimha marked this pull request as draft January 24, 2024 07:11
@dotansimha dotansimha marked this pull request as ready for review January 24, 2024 07:14
@dotansimha dotansimha mentioned this pull request Jan 24, 2024
Merged
@zhongzc zhongzc merged commit b77884c into tikv:master Jan 24, 2024
5 checks passed
@dotansimha dotansimha deleted the web-time-wasm branch January 24, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongzc zhongzc zhongzc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotansimha @zhongzc