Trim slashes between origin and optional first param #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that there is only ever exactly one slash (
/) between a generated URL's origin and path. This fixes an issue where it was possible to end up with a double slash if the very first segment of the path is an optional, omitted, route parameter. For example,{locale?}/foocould generatedomain.com//fooif thelocaleparam wasn't provided.Note: This PR intentionally does not change the behaviour of omitted optional route params inside the route path. It's still possible to get double slashes there, e.g. with something like
/foo/{param?}/bar, but this matches the behaviour of Laravel'sroute()function.Resolves the issue discussed in #616. See #616 (reply in thread).