Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OOPS section under CS Fundamentals in Interview Preparation #181

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

Arun9739
Copy link
Contributor

Adding OOPS section :

Issue No : #171

  • I have added OOPS section under Compputer Science Fundamentals in Interview Preparation.
  • I have also added related video inks and notes.
  • I have maintained the pattern, color and style of the webpage.
  • The web page remains stable after my changes.

Screenshot :

image

@Arun9739
Copy link
Contributor Author

@narayan954 Please review my changes

Copy link
Collaborator

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Arun9739 , while reviewing these changes , I found that your addition has some issues. Can you please fix them?

pr 181

  1. The accordion is not functioning properly. Clicking on this element doesn't close others (As you can see in the ss)
  2. Font color isn't configured properly. It should adapt to different modes as other elements.

@tier3guy tier3guy merged commit 4efdf65 into tier3guy:master Sep 23, 2022
@Arun9739 Arun9739 deleted the OOPS-add branch September 30, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants