Skip to content

Commit

Permalink
Merge pull request #1557 from TimTaylor/patch-as_tibble
Browse files Browse the repository at this point in the history
  • Loading branch information
krlmlr committed Dec 19, 2023
2 parents e78ea46 + 9a6911b commit 3c4744a
Show file tree
Hide file tree
Showing 6 changed files with 451 additions and 107 deletions.
4 changes: 4 additions & 0 deletions R/as_tibble.R
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ as_tibble.data.frame <- function(x, validate = NULL, ...,
deprecate_stop("2.0.0", "tibble::as_tibble(validate = )", "as_tibble(.name_repair =)")
}

if (!inherits(x, "tbl_df") && !identical(class(x), "data.frame")) {
x <- as.data.frame(x)
}

old_rownames <- raw_rownames(x)
if (is.null(.rows)) {
.rows <- nrow(x)
Expand Down
21 changes: 18 additions & 3 deletions revdep/README.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,24 @@
# Revdeps

## New problems (2)
## Failed to check (11)

|package |version |error |warning |note |
|:----------------|:-------|:-----|:-------|:----|
|bulkreadr |? | | | |
|dplyr |? | | | |
|historicalborrow |? | | | |
|LexisNexisTools |? | | | |
|matrixset |? | | | |
|NMsim |? | | | |
|RevGadgets |? | | | |
|simaerep |? | | | |
|simTool |? | | | |
|tidyposterior |? | | | |
|workflowsets |? | | | |

## New problems (1)

|package |version |error |warning |note |
|:-------|:-------|:------|:-------|:----|
|[ggESDA](problems.md#ggesda)|0.2.0 |__+1__ |__+1__ | |
|[RSDA](problems.md#rsda)|3.0.13 |__+1__ |__+1__ | |
|[NMdata](problems.md#nmdata)|0.1.2 |__+1__ | | |

13 changes: 4 additions & 9 deletions revdep/cran.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,15 @@
## revdepcheck results

We checked 14 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
We checked 14 reverse dependencies (3 from CRAN + 11 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.

* We saw 2 new problems
* We saw 1 new problems
* We failed to check 0 packages

Issues with CRAN packages are summarised below.

### New problems
(This reports the first line of each new failure)

* ggESDA
checking examples ... ERROR
checking re-building of vignette outputs ... WARNING

* RSDA
checking examples ... ERROR
checking re-building of vignette outputs ... WARNING
* NMdata
checking tests ... ERROR

Loading

0 comments on commit 3c4744a

Please sign in to comment.