Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise space-filling designs #307

Closed
topepo opened this issue Aug 7, 2023 · 0 comments · Fixed by #329
Closed

Revise space-filling designs #307

topepo opened this issue Aug 7, 2023 · 0 comments · Fixed by #329
Labels
feature a feature request or enhancement

Comments

@topepo
Copy link
Member

topepo commented Aug 7, 2023

We currently make our space-filling designs on-the-fly using functions in DiceDesign. They use random numbers and don't always produce the best results.

This website has compiled designs that have been optimized for varying numbers of parameters and sizes. They are free of charge and I've already scraped them.

I'd like to:

  • For grid_latin_hypercube(), use the Audze-Eglais designs whenever possible (if they are available for the chosen number of parameters and size). Otherwise, do what we've done before.
  • Add a new grid_max_min() function to look up the L2 and L1 designs. We might consider moving the default grid in tune to use this. It goes up to 10 parameters so we are probably fine.

This is also made me feel that we should adjust the grid_max_entropy() function to raise the values of the radius and the number of iterations to make them more stable. We could also add a tries argument that will use different random numbers and take the design with the best results.

@EmilHvitfeldt EmilHvitfeldt added the feature a feature request or enhancement label Aug 7, 2023
topepo pushed a commit to topepo/dials that referenced this issue Apr 10, 2024
hfrick added a commit that referenced this issue Jun 14, 2024
* initial skeleton

* get values

* work with values

* more roxygen2 and documentation

* process file in man/rmd

* small updates

* some documentation updates

* add a uniform design reference

* add the existing designs to the function

* unit tests

* removed remote

* added some missing tests

* summary of updates for #307

* one argument per line

* updated from reviewer feedback

* update unit tests

* remove comment

* tweak wording

* remove comment

---------

Co-authored-by: ‘topepo’ <‘[email protected]’>
Co-authored-by: Hannah Frick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants