Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Raspberry Pi Pico LCD Shields by PiMoroni #243

Merged
merged 6 commits into from
Jul 13, 2024
Merged

Conversation

rexut
Copy link
Member

@rexut rexut commented Jun 30, 2024

Fixes #239 and also brings many improvements in shield documentation:

Copy link

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

boards/shields/rpi_pico_lcd/pimoroni_pico_lcd_1_44.overlay Outdated Show resolved Hide resolved
boards/shields/rpi_pico_lcd/pimoroni_pico_lcd_1_44.overlay Outdated Show resolved Hide resolved
boards/shields/rpi_pico_lcd/pimoroni_pico_lcd_1_44.overlay Outdated Show resolved Hide resolved
boards/shields/rpi_pico_lcd/pimoroni_pico_lcd_1_44.overlay Outdated Show resolved Hide resolved
boards/shields/rpi_pico_lcd/pimoroni_pico_lcd_2.overlay Outdated Show resolved Hide resolved
boards/shields/rpi_pico_lcd/waveshare_pico_lcd_1_3.overlay Outdated Show resolved Hide resolved
boards/shields/rpi_pico_lcd/waveshare_pico_lcd_1_3.overlay Outdated Show resolved Hide resolved
boards/shields/rpi_pico_lcd/waveshare_pico_lcd_1_3.overlay Outdated Show resolved Hide resolved
boards/shields/rpi_pico_lcd/waveshare_pico_lcd_1_3.overlay Outdated Show resolved Hide resolved
@rexut
Copy link
Member Author

rexut commented Jul 1, 2024

see also review comments in PR #238

@rexut
Copy link
Member Author

rexut commented Jul 2, 2024

see also review comments in PR #238

done

@rexut
Copy link
Member Author

rexut commented Jul 2, 2024

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

Found the new shields here: https://bridle.tiac-systems.net/ghpr/doc/PR-243/bridle/boards/shields/rpi_pico_lcd/doc/index.html

tobiaskaestner
tobiaskaestner previously approved these changes Jul 9, 2024
Copy link
Contributor

@tobiaskaestner tobiaskaestner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In addition to the SPI0 bus, the node references for the SPI1 bus are now
also provided. These can be used in other DTS overlays if, for example,
shields are dependent on this additional SPI bus.

Signed-off-by: Stephan Linz <[email protected]>
There are Pico LCD shields that rely on the additional SPI0 bus.
This restructuring opens the way for their integration.

Signed-off-by: Stephan Linz <[email protected]>
The new part of the Raspberry Pi Pico LCD shield by PiMoroni is:

  * PIM543 Pico Display Pack, here in Bridle known as
    PiMoroni Pico LCD 1.44 (pimoroni_pico_lcd_1_44)

supported features:

  * display API (zephyr/samples/drivers/display)
  * LVGL stack (zephyr/samples/subsys/display/lvgl)
  * input API (zephyr/samples/subsys/input/input_dump)

supported platforms:

  * Raspberry Pi Pico (rpi_pico)
  * Raspberry Pi Pico W (rpi_pico_w)
  * Waveshare RP2040 Plus 4MB (waveshare_rp2040_plus)
  * Waveshare RP2040 Plus 16MB (waveshare_rp2040_plus@16mb)

Signed-off-by: Stephan Linz <[email protected]>
The new part of the Raspberry Pi Pico LCD shield by PiMoroni is:

  * PIM580 Pico Display Pack 2.0, here in Bridle known as
    PiMoroni Pico LCD 2 (pimoroni_pico_lcd_2)

supported features:

  * display API (zephyr/samples/drivers/display)
  * LVGL stack (zephyr/samples/subsys/display/lvgl)
  * input API (zephyr/samples/subsys/input/input_dump)

supported platforms:

  * Raspberry Pi Pico (rpi_pico)
  * Raspberry Pi Pico W (rpi_pico_w)
  * Waveshare RP2040 Plus 4MB (waveshare_rp2040_plus)
  * Waveshare RP2040 Plus 16MB (waveshare_rp2040_plus@16mb)

Signed-off-by: Stephan Linz <[email protected]>
Support binary artifacts with file suffix ".drawio".

Signed-off-by: Stephan Linz <[email protected]>
Add new Raspberry Pi Pico LCD Shields:

- Pico LCD 1.44 shield by PiMoroni (PIM543, "Pico Display Pack")
- Pico LCD 2 shield by PiMoroni (PIM580, "Pico Display Pack 2.0")

Signed-off-by: Stephan Linz <[email protected]>
@rexut rexut marked this pull request as ready for review July 13, 2024 10:25
Copy link
Contributor

@tobiaskaestner tobiaskaestner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rexut rexut merged commit 489e40f into main Jul 13, 2024
10 checks passed
@rexut rexut deleted the devel/issues/239 branch July 13, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HW] PiMoroni Raspberry Pi Pico LCD Modules as Shields
2 participants