Adjust data directories #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
MyXOF
requested changes
Mar 22, 2018
iotdb/conf/iotdb-engine.properties
Outdated
| # If its prefix is a drive specifier followed by "\\", or if its prefix is "\\\\", then the pathname is absolute. Otherwise, it is relative. | ||
| # If it is absolute, system will save the data in exact location it points to. | ||
| # If it is relative, system will save the data in the relative path directory it represents under the IoTDB folder(i.e., %IOTDB_HOME%). | ||
| # Note: If data_dir is assigned an empty string(i.e.,zero-length), it will be handled as a relative path. |
There was a problem hiding this comment.
这两段注释有很多重复的地方，考虑合并下？需要区分不同操作系统的地方单独说明？
| */ | ||
| public void updateSysPath() { | ||
| if(sysDir==null) { | ||
| sysDir="data"+File.separatorChar+"system"; |
| return; | ||
| } | ||
| else { | ||
| String homeDir = System.getProperty("IOTDB_HOME",null); |
There was a problem hiding this comment.
IOTDB_HOME在TsFileDBConstant这个类里面定义了
| | D:\\iotdb\iotdb | "" | D:\\iotdb\iotdb\ | | ||
|
|
||
| */ | ||
| public void updateWalPath() { |
There was a problem hiding this comment.
这个函数和上面的函数分别对sys和wal进行复制，代码有很多相似的地方（根据IOTDB_HOME来设置），相似的代码可以考虑合并为一个函数
9bd4a94
to
afead38
Compare
f746f8c
to
0dbe7e8
Compare
MyXOF
previously approved these changes
Apr 9, 2018
MyXOF
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data_directory: A
system_directory: B
wal_directory: C
E.g., for linux platform:
delta->A/settled
overflow->A/overflow
index->A/index
digest->B/info
metadata->B/schema
derby->B/derby
wal->C/wal