Compatibility with Rails 7 #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently trying to upgrade to Rails 7 but having compatibility issues due to this, it would be awesome if this could be merged or an update given on this issue. |
3b7
added a commit
to shirtspace/neat
that referenced
this pull request
Jan 6, 2023
taking inspiration from thoughtbot/bourbon#1109 while efforst are underway to remove neat dependency in the 'shirtspace' repo the upgrade for rails 7 is looming. this patch to our forked version should allow us to be be able to upgrade to rails 7 without having to wait for a complete removal of the neat gem
|
If someone can help by confirming this change still works when running with Rails 6, we can get it merged. Thanks. |
|
This style of initializing an engine has at least been around since rails 5.1 https://api.rubyonrails.org/v5.1/classes/Rails/Engine.html#class-Rails::Engine-label-Configuration I think this is good to go |
saturnflyer
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change addresses an undefined method error that happens at boot time when the bourbon gem is in the Gemfile. After this change Rails will boot and the files under /core are available to the app.
The problem is with line 6 in lib/bourbon.rb. My guess is that
assetsis not available onRails::Engine::Configurationdue to boot changes related to the Zeitwerk transition, and/or related to Sprockets no longer being a dependency.