Allow commands with spaces to be constructed as new Commands #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you were using the `appraisal` executable and passed an argument that
contained spaces, those spaces would not be preserved when Appraisal
went to execute the full command. For instance, this command...
appraisal 4.2 rspec spec/some/file_spec.rb -e "some example group"
*Should* be expanded as follows:
BUNDLE_GEMFILE=$PWD/gemfiles/4.2.gemfile rspec spec/some/file_spec.rb -e "some example group"
...but before this commit would be incorrectly expanded as follows:
BUNDLE_GEMFILE=$PWD/gemfiles/4.2.gemfile rspec spec/some/file_spec.rb -e some example group
| run 'appraisal 1.0.0 ruby -rbundler/setup -rdummy "test with spaces.rb"' | ||
| } | ||
|
|
||
| expect(&assertion).not_to raise_error |
There was a problem hiding this comment.
Can you add assertion for output as well? I think I care more that the command get executed and yield correct result than if we return zero exit status.
|
@sikachu Ready for re-review. |
|
@mcmire I squashed the commits and merged them. Thank you! |
mcmire
added a commit
that referenced
this pull request
Mar 4, 2015
If you were using the `appraisal` executable and passed an argument that
contained spaces, those spaces would not be preserved when Appraisal
went to execute the full command. For instance, this command...
appraisal 4.2 rspec spec/some/file_spec.rb -e "some example group"
*Should* be expanded as follows:
BUNDLE_GEMFILE=$PWD/gemfiles/4.2.gemfile rspec spec/some/file_spec.rb -e "some example group"
...but before this commit would be incorrectly expanded as follows:
BUNDLE_GEMFILE=$PWD/gemfiles/4.2.gemfile rspec spec/some/file_spec.rb -e some example group
Close #86
|
Sweet, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you were using the
appraisalexecutable and passed an argument thatcontained spaces, those spaces would not be preserved when Appraisal
went to execute the full command. For instance, this command...
Should be expanded as follows:
...but before this commit would be incorrectly expanded as follows: