Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSL aliases mixed up? #78

Closed
maxlinc opened this issue Dec 9, 2014 · 3 comments
Closed

DSL aliases mixed up? #78

maxlinc opened this issue Dec 9, 2014 · 3 comments
Assignees
@sikachu
Milestone
v1.0.3

Comments

@maxlinc
Copy link

maxlinc commented Dec 9, 2014

It seems like the aliases were swapped unless the bundler DSL used to be different.

In the Bundler DSL:

  • #platforms is aliased as #platform
  • #group does not have an alias

In the Appraisal DSL:

  • #group is aliased as #groups
  • #platform does not have an alias
@sikachu
Copy link
Contributor

sikachu commented Jan 2, 2015

Good catch. Seems to be a quick fix, so let me do that.

Note that we'll have to maintain groups until we're shipping 2.0 though. So I'll keep this open until then.

@sikachu sikachu self-assigned this Jan 2, 2015
@sikachu sikachu modified the milestones: v2.0, v1.0.3, v2.0.0 Jan 2, 2015
@sikachu sikachu mentioned this issue Jan 2, 2015
Closed
@sikachu
Copy link
Contributor

sikachu commented Jan 2, 2015

Actually, I made #83 to take care of removal. Let's just make sure we have platforms here.

@sikachu sikachu closed this as completed in d715462 Jan 2, 2015
@sikachu
Copy link
Contributor

sikachu commented Jan 2, 2015

Thanks for reporting!

sikachu pushed a commit that referenced this issue Mar 4, 2015
Match Bundler's DSL on group and platforms
ed52caa 
* Add `platform` alias.
* Deprecate `groups`.

Fixes #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sikachu sikachu

Labels
None yet
Projects
None yet
Milestone
v1.0.3
Development

No branches or pull requests
2 participants
@sikachu @maxlinc