Fix up "Show" label on index page #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| visit edit_admin_customer_path(customer) | ||
|
|
||
| expect(page).to have_link("Show #{displayed(customer)}") |
There was a problem hiding this comment.
This may be for my own reference, but - where is this mysterious displayed method defined? Don't see it in this spec, or rails_helper. ¯_(ツ)_/¯
There was a problem hiding this comment.
Meant to push to this branch, but accidentally pushed to master. 😕
This commit fixes up the include logic for the displayed helper.
9787489
Problem: In fcd3fc7, we moved logic for displaying resources into dashboard classes. Unfortunately, we missed migrating the edit page's "Show" link over to use the new logic. It is currently displaying the resource using Ruby's built-in `to_s` method. Solution: Migrate the button to the new method of displaying resources.
c-lliope
force-pushed
the
gw-show-button
branch
from
c7c6328
to
39b0ce7
Compare
c-lliope
added a commit
that referenced
this pull request
Dec 9, 2015
Changes: ``` * [#251] [FEATURE] Raise a helpful error when an attribute is missing from `ATTRIBUTE_TYPES` * [#298] [FEATURE] Support ActiveRecord model I18n translations * [#312] [FEATURE] Add a `nil` option to `belongs_to` form fields * [#231] [UI] Fix layout issue on show page where a long label next to an empty value would cause following fields on the page to be mis-aligned. * [#309] [UI] Fix layout issue in datetime pickers where months and years would not wrap correctly. * [#306] [UI] Wrap long text lines (on word breaks) on show pages * [#214] [UI] Improve header layout when there is a long page title * [#198] [UI] Improve spacing around bottom link in sidebar * [#206] [UI] Left-align checkboxes in boolean form fields * [#315] [UI] Remove the `IDS` suffix for `HasMany` form field labels * [#259] [BUGFIX] Make installation generator more robust by ignoring dynamically generated, unnamed models * [#243] [BUGFIX] Fix up a "Show" button on the edit page that was not using the `display_resource` method. * [#248] [BUGFIX] Improve polymorphic relationship's dashboard class detection. * [#247] [BUGFIX] Populate `has_many` and `belongs_to` select boxes with the current value of the relationship. * [#217] [I18n] Dutch * [#263] [I18n] Swedish * [#272] [I18n] Danish * [#270] [I18n] Don't apologize about missing relationship support. * [#237] [I18n] Fix broken paths for several I18n files (de, es, fr, pt-BR, vi). * [#266] [OPTIM] Save a few database queries by using cached counts ```
This was referenced Dec 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In fcd3fc7, we moved logic for displaying resources into dashboard
classes. Unfortunately, we missed migrating the edit page's "Show" link
over to use the new logic. It is currently displaying the resource using
Ruby's built-in
to_smethod.Solution:
Migrate the button to the new method of displaying resources.