Skip to content

Commit

Permalink
cmd/go: include Go toolchain information in build ID
Browse files Browse the repository at this point in the history
This causes packages and binaries built by Go 1.5 to look
out of date to Go 1.6 and vice versa, so that when you flip
between different Go versions but keep the same GOPATH,
the right rebuilding happens at each flip.

Go 1.4 binaries will also look out of date to Go 1.5,
but Go 1.5 binaries will not look out of date to Go 1.4
(since Go 1.4 doesn't have anything like this).
People flipping between Go 1.4 and Go 1.5 will still
need to use go install -a every time to flip to Go 1.4,
but not when they flip back to Go 1.5.

Fixes golang#6534.
Fixes golang#10702.

Change-Id: I0ae7f268f822d483059a938a4f22846ff9275b4c
Reviewed-on: https://go-review.googlesource.com/10760
Reviewed-by: Ian Lance Taylor <[email protected]>
Reviewed-by: Andrew Gerrand <[email protected]>
  • Loading branch information
rsc committed Jun 15, 2015
1 parent 43aac4f commit 3ab9ff1
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions src/cmd/go/pkg.go
Original file line number Diff line number Diff line change
Expand Up @@ -724,6 +724,27 @@ func (p *Package) load(stk *importStack, bp *build.Package, err error) *Package
for _, file := range inputFiles {
fmt.Fprintf(h, "%s\n", file)
}

// Include the content of runtime/zversion.go in the hash
// for package runtime. This will give package runtime a
// different build ID in each Go release.
if p.Standard && p.ImportPath == "runtime" {
data, _ := ioutil.ReadFile(filepath.Join(p.Dir, "zversion.go"))
fmt.Fprintf(h, "zversion %q\n", string(data))
}

// Include the build IDs of any dependencies in the hash.
// This, combined with the runtime/zversion content,
// will cause packages to have different build IDs when
// compiled with different Go releases.
// This helps the go command know to recompile when
// people use the same GOPATH but switch between
// different Go releases. See golang.org/issue/10702.
for _, dep := range p.Deps {
p1 := deps[dep]
fmt.Fprintf(h, "dep %s %s\n", p1.ImportPath, p1.buildID)
}

p.buildID = fmt.Sprintf("%x", h.Sum(nil))

return p
Expand Down

0 comments on commit 3ab9ff1

Please sign in to comment.