added contrib/salsa_flexible.py and updated README as per issue#4 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR looks great @andres-fr. I like the way you rewrite the feature extractor. Kudos to |
|
thanks to you for the amazing research! |
|
Closes #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! as discussed in issue #4, I've added the on-the-fly functionality as a stand-alone script under
contrib, and updated theREADMEaccordingly with a brief note.Regarding linting,
flake8only complained about 3 lines longer than 80chars that I left with inline comments for clarity, let me know if you want me to change them.Regarding licensing, I adopted MIT following the main repo. Also let me know if there are any issues.
Cheers!
Andres