Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: index unicode fields for icons for enable unicode search #65

Merged

Conversation

grimen
Copy link
Contributor

@grimen grimen commented Jan 11, 2016

Additional: Grouped operations by the comments to make the code a bit
more readable.

Additional: Grouped operations by the comments to make the code a bit
more readable.
@grimen grimen changed the title feature: index unicode fields for icons for enable unicode search feature: index unicode fields for icons for enable unicode search - fixes #50 Jan 11, 2016
@grimen grimen changed the title feature: index unicode fields for icons for enable unicode search - fixes #50 feature: index unicode fields for icons for enable unicode search Jan 11, 2016
@grimen
Copy link
Contributor Author

grimen commented Jan 11, 2016

fixes #50

@redox
Copy link
Contributor

redox commented Jan 11, 2016

LGTM 👍

thomaspark added a commit that referenced this pull request Jan 24, 2016
feature: index `unicode` fields for icons for enable unicode search
@thomaspark thomaspark merged commit eb077e2 into thomaspark:gh-pages Jan 24, 2016
@thomaspark
Copy link
Owner

Merged and re-indexed.

@redox, is there a way to set fuzziness per attribute? I think it's preferable to have exact matching on hex searches.

@thomaspark thomaspark mentioned this pull request Jan 24, 2016
@redox
Copy link
Contributor

redox commented Feb 16, 2016

@thomaspark sorry for being late here. Yes we can use the disableTypoToleranceOnAttributes to disable the typo-tolerance on some attributes:

    index.setSettings({
      'attributesToIndex': ["name", "tags", "unicode"],
      'disableTypoToleranceOnAttributes': ['unicode'],
      'customRanking': ["asc(name)"],
      'queryType': 'prefixAll'
    });

Let me know what you guys think! @thomaspark @grimen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants