Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a loader image #14

Closed
wants to merge 1 commit into from
Closed

Conversation

jenil
Copy link
Contributor

@jenil jenil commented Dec 18, 2013

Adds a nice loader image in the icon area till they are all populated.

@thomaspark
Copy link
Owner

The loading style can definitely be improved, right now it's jarring.

If we did go with a loader, it would be much more fitting to use fa-spinner with a CSS rotate animation!

I wonder if a separate loader animation is even necessary — the icons are loading for me in under 500ms and the spinner is barely perceptible. How about fading in the icons and section titles on load instead? Less jarring, and less stuff getting between the user and the icons.

@jenil
Copy link
Contributor Author

jenil commented Dec 18, 2013

The only point of getting a loader was getting rid of the suddenly appearing icons. We need to figure out a way to populate the icons in a better way.

@jenil
Copy link
Contributor Author

jenil commented Dec 21, 2013

Hey @thomaspark check the latest commit.

@thomaspark
Copy link
Owner

This animation would definitely work if this was a standard search. But since it triggers on each key press, there's a blinking effect that is pretty distracting. The animation is even triggered even when the search results don't change (like a query going from "point" to "pointer").

The bigger issue with GlyphSearch right now is that on page load, all of the section headers briefly flash into view. The section headers should probably be shown only after the icons have been loaded.

Also, with a permalink, the search box and dropdown flash their default states before updating.

@jenil
Copy link
Contributor Author

jenil commented Dec 28, 2013

Yeah I don't think updating the loading of icons should be working upon, inside the loading on the page itself needs to be worked upon. I think we should parse the URL first and only then load the content on the page.

@jenil
Copy link
Contributor Author

jenil commented Mar 14, 2014

I am closing this as GlyphSearch was updated to v1.1.0.

@jenil jenil closed this Mar 14, 2014
@jenil jenil deleted the development branch March 14, 2014 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants