Show actual subtotal and prices #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @thomasKn on Vercel. @thomasKn first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @AishaBlake! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm not sure if you're taking suggestions on this project but I wanted to share just in case...
As a store owner, I'm only ever going to show the subtotal in the cart, before the customer goes to checkout. Right now, the cart says it's showing the subtotal but is actually showing the
totalAmount, which includes taxes.The
Moneycomponent is also rounding prices wherever they show up. That isn't an issue for my store because all our prices are in whole dollars but it made figuring out why the subtotal was wrong more confusing because it wasn't usually quite showing the correct total including taxes. For most people, rounding prices and then actually charging something else isn't an option.If you're open to it, I'm happy to share other thoughts as I build with this. Thanks for the starter!