Merge pull request #104 from ahuigo/master

bugfix: Subset(["a","k"],["a","b"]) should return false
thoas · Nov 28, 2020 · 17a41bd · 17a41bd
2 parents e5885af + e2384c7
commit 17a41bd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/subset.go b/subset.go
@@ -35,9 +35,7 @@ func Subset(x interface{}, y interface{}) bool {
  if !Contains(yValue.Interface(), xValue.Index(i).Interface()) {
  return false
  }
- return true
  }
 
- return false
-
+ return true
 }
diff --git a/subset_test.go b/subset_test.go
@@ -14,6 +14,9 @@ func TestSubset(t *testing.T) {
  r = Subset([]string{"foo", "bar"},[]string{"foo", "bar", "hello", "bar", "hi"})
  is.True(r)
 
+ r = Subset([]string{"foo", "bar","extra"},[]string{"foo", "bar", "hello", "bar", "hi"})
+ is.False(r)
+
  r = Subset([]string{"hello", "foo", "bar", "hello", "bar", "hi"}, []string{})
  is.False(r)