Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out empty path components #1

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Filter out empty path components #1

merged 2 commits into from
Apr 21, 2023

Conversation

nehzata
Copy link
Contributor

@nehzata nehzata commented Apr 21, 2023

No description provided.

@nehzata nehzata requested a review from alecthomas April 21, 2023 06:45
alecthomas
alecthomas requested changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work

@alecthomas
Copy link
Collaborator

alecthomas commented Apr 21, 2023 •
edited
Loading

The routing logic below relies on parts[0] being empty

@nehzata
Copy link
Contributor Author

nehzata commented Apr 21, 2023

Yet again I was too hopeful. hahah

@nehzata
Copy link
Contributor Author

nehzata commented Apr 21, 2023

@alecthomas updated. How does it look now?

@alecthomas alecthomas merged commit c8cbe20 into master Apr 21, 2023
@alecthomas alecthomas deleted the fix-filter-empty-path-components branch April 21, 2023 08:16
@nehzata nehzata restored the fix-filter-empty-path-components branch April 21, 2023 13:02
@nehzata nehzata deleted the fix-filter-empty-path-components branch April 21, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nehzata @alecthomas