Untitled #8
Open
Untitled #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todo: change call from user to app, to load all users' comments
…Press Conflicts: facebook-comments.php
…hich can be used to delete posts.
… on xampp/wamp servers.
…ing json_decode. As a result, changed object op ('->') accesses to subscripted accesses.
Added check so people who use the same fb app id for multiple sites (bad!) will only see comments relevant to the site they are currently on.
…o cURL options so facebook won't deny us GETs.
…upon initial install.
… skipped because it belongs to another instance of this fb app id.
facebook-comments.php: settings arrays, constants, and all program hooks and filters. facebook-comments-recentcomments.php: all of the code for the Recent Comments widgets, both the website and dashboard flavors. facebook-comments-admin.php: the admin settings page. facebook-comments-core.php: core functions (e.g., logging, getFbApi, etc.). facebook-comments-display.php: actual facebook comment inclusion functions. Previously located at the bottom of the facebook-comments-functions.php file. facebook-comments-combinecomments.php: all combined comment count functionality. facebook-comments-ajax.php: unchanged.
…ments on the dashboard widget.
…t or app secret are not input.
…-for-WordPress into devel
Other minor changes, see http:https://we8u.com/fbc3
…ied from previous installations
…ing. Cause: unknown
…ariations of fb comment system, various tweaks
… causing the HTML to be invalid.
Start using git again
Fix for comment count not updating
Redundant Anchor tags causing invalid HTML in the widget
…w and displays cleanly
The previous fix fixed comment counts to be displayed only the in post's page itself and not in page such as the home page of the blog etc (where you only saw a "comments" like without the number of comments). This commit fixes it by adding our very own javascript that fetches all the comment counts when any page loads and updates the links accordingly. What more, because we now call the FQL server ourselves, we have a callback to rely on in order to make sure that the correct pluralization of the comments count is displayed (e.g. '1 comment' vs '2 comments')
Fixing comments count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey graham. I also have a devel branch in which I changed the settings page and updated the help message when the app id check fails. I also updated the settings method itself from the deprecated POST method to using wp api calls. I'll put both and let you decide which branch to use.
cheers!