Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license command --json and --xml arguments usage #99

Merged
merged 2 commits into from
Oct 30, 2021

Conversation

bacali95
Copy link
Collaborator

closes #77

@bacali95 bacali95 requested a review from thevpc October 30, 2021 15:25
@bacali95 bacali95 self-assigned this Oct 30, 2021
@thevpc
Copy link
Owner

thevpc commented Oct 30, 2021

could you use

getSession().out().printf(licenseString)
or
getSession().out().printlnf(licenseString)

instead of

getSession().formats().object(licenseString).println()

Besides, did you check why you needed to do configure(false, args). Normally the session is already reading the '--xml' in getSession().configureLast(commandLine)

@bacali95
Copy link
Collaborator Author

I think since the license command does not have any extra arguments so we don't need the configure(false, args) again, correct?

@thevpc
Copy link
Owner

thevpc commented Oct 30, 2021

right!

@thevpc thevpc merged commit 73dcd91 into master Oct 30, 2021
@thevpc thevpc deleted the fix/license-command-json-format branch October 30, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuts license --json
2 participants