Union Events Timeline issue #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has basic outline. Needs to be styled better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
This pull request is for the Union Events Timeline issue (#109).
Describe the Changes
I made a new page type (UnionTimeline) that has fields for individual events (UnionEvent). A featured photo, date, descriptions can be added to each event as well as authors to the page itself. Tooltips are used to represent definitions for RPI commonly used terms.
Still To Do
We could expand the featured photos by using the same method as in gallery photos. I am struggling with this part, but maybe @jlyon1 could look at this/help me with it. Also, I need to add photographer credit to each featured photo and haven't thought about how to style this or captions. Also, the authors show up at the top of the Union Timeline page but the page title does not show up on the author's staff page. I left it like this because it doesn't make sense to me to credit this timeline as article for that author.
Problems
Parts of the code for this new page resemble that of ArticlePage. However, since they serve two different functionalities, I didn't think it made sense to make UnionTimeline a sub class of ArticlePage.
Testing
I tested this locally by making a Union Timeline page and then adding content to its admin page. I used the print issue timeline as reference for what text to put in each event. I would suggest using this same method to test the implementation since this page does not really rely on any existing classes.