Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DERCBOT-1060] Delete obsolete FAQ roles #1652

Conversation

assouktim
Copy link
Contributor

No description provided.

@Benvii
Copy link
Member

Benvii commented Jun 27, 2024

Hi,
Can you create an issue to describe the change and why we are making it ?

I have added this subject for the next "Tock Community Virtual Coffe ☕️🤖" on Thursday, 4 July⋅4:00 – 5:00pm. This is clearly a huge breaking change (if someone is using those role in the community), I think that we should first deprecate the roles with warning then remove them.

I'm not sure it's the best approach be we could wrap the auth provider "toTockUser()" and remap the following role (and remove duplicates) :

  • faqBotUser => botUser
  • faqNlpUser => nlpUser

It's call here and could be temporary wrapped here with a warning indicating :
https://github.com/theopenconversationkit/tock/blob/master/shared/src/main/kotlin/vertx/WebVerticle.kt#L899

@assouktim
Copy link
Contributor Author

issue : #1656

@Benvii Benvii marked this pull request as ready for review July 1, 2024 08:19
@assouktim assouktim marked this pull request as draft July 1, 2024 12:22
Copy link
Member

@Benvii Benvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok but it will still break for Authentication providers that return those roles as as they will be refused by the Bot Admin API.

I was mentioning wrapping them mapping it to BotUser and NlpUser after the authentication provider is called in my comment : #1652 (comment)

@Benvii Benvii marked this pull request as ready for review July 9, 2024 06:50
@vsct-jburet vsct-jburet added this to the 24.3.4 milestone Jul 9, 2024
@vsct-jburet vsct-jburet merged commit 84e8280 into theopenconversationkit:master Jul 9, 2024
@Benvii
Copy link
Member

Benvii commented Jul 9, 2024

We should also create a ticket to remove this part https://github.com/theopenconversationkit/tock/pull/1652/files#diff-bfcbf9099787d7fe4cf1aae4918633ca6ac816ece6f83d1fd8d1a0ccbcd857e8R901 in a future version.

==> Done here : #1680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants