-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DERCBOT-1060] Delete obsolete FAQ roles #1652
[DERCBOT-1060] Delete obsolete FAQ roles #1652
Conversation
Hi, I have added this subject for the next "Tock Community Virtual Coffe ☕️🤖" on Thursday, 4 July⋅4:00 – 5:00pm. This is clearly a huge breaking change (if someone is using those role in the community), I think that we should first deprecate the roles with warning then remove them. I'm not sure it's the best approach be we could wrap the auth provider "toTockUser()" and remap the following role (and remove duplicates) :
It's call here and could be temporary wrapped here with a warning indicating : |
issue : #1656 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok but it will still break for Authentication providers that return those roles as as they will be refused by the Bot Admin API.
I was mentioning wrapping them mapping it to BotUser and NlpUser after the authentication provider is called in my comment : #1652 (comment)
897214a
to
87a6fdc
Compare
We should also create a ticket to remove this part https://github.com/theopenconversationkit/tock/pull/1652/files#diff-bfcbf9099787d7fe4cf1aae4918633ca6ac816ece6f83d1fd8d1a0ccbcd857e8R901 in a future version. ==> Done here : #1680 |
No description provided.