Skip to content

Commit

Permalink
fixed breaking realtimetest and added the conversion of 'total:disabl…
Browse files Browse the repository at this point in the history
…ed' to 'total' in input also added Herrenberg to readme
  • Loading branch information
theofre committed Jun 21, 2024
1 parent a8d6d2c commit eebc042
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ We support following data sources:
| Stadt Stuttgart | car | push (json) | `stuttgart` | yes |
| Stadt Ulm | car | pull | `ulm` | yes |
| Verband Region Stuttgart: Park and Ride | car | push (xlsx) | `vrs_p_r` | no |
| Stadt Herrenberg | car | pull | `herrenberg` | no |

New converters for new sources are always welcome, please have a look at "Contribute" below.

Expand Down
4 changes: 3 additions & 1 deletion src/parkapi_sources/converters/herrenberg/converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def get_static_parking_sites(self) -> tuple[list[StaticParkingSiteInput], list[I
return static_parking_site_inputs, static_parking_site_errors

def get_realtime_parking_sites(self) -> tuple[list[RealtimeParkingSiteInput], list[ImportParkingSiteException]]:
pass
return [], []
# since there is no realtimedata this is just skipped

def _get_remote_data(self) -> list[dict]:
Expand All @@ -69,5 +69,7 @@ def _get_remote_data(self) -> list[dict]:

items: list[dict] = []
for item in result_dict['lots']:
if item['lot_type'] == 'Barrierefreier-Parkplatz':
item['total'] = item.pop('total:disabled')
items.append(item)
return items
8 changes: 5 additions & 3 deletions src/parkapi_sources/converters/herrenberg/mapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
Use of this source code is governed by an MIT-style license that can be found in the LICENSE.txt.
"""


from parkapi_sources.converters.herrenberg.validation import HerrenbergParkingSiteInput
from parkapi_sources.models import StaticParkingSiteInput
from parkapi_sources.models.enums import ParkAndRideType
Expand All @@ -16,7 +15,10 @@ def map_static_parking_site(self, herrenbergparkingsiteinput: HerrenbergParkingS
fee = True
herrenbergparkingsiteinput.ride = ParkAndRideType.NO


disabled = 0
if herrenbergparkingsiteinput.lot_type == 'Barrierefreier-Parkplatz':
disabled = herrenbergparkingsiteinput.total
herrenbergparkingsiteinput.total = 0

return StaticParkingSiteInput(
uid=herrenbergparkingsiteinput.id,
Expand All @@ -33,6 +35,6 @@ def map_static_parking_site(self, herrenbergparkingsiteinput: HerrenbergParkingS
fee_description=herrenbergparkingsiteinput.fee_hours,
opening_hours=herrenbergparkingsiteinput.opening_hours,
has_fee=fee,

capacity_disabled=disabled,

)
5 changes: 3 additions & 2 deletions tests/converters/herrenberg_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,6 @@ def test_get_static_parking_sites(herrenberg_pull_converter: HerrenbergPullConve
validate_static_parking_site_inputs(static_parking_site_inputs)

@staticmethod
def test_get_realtime_parking_sites():
pass
def test_get_realtime_parking_sites(herrenberg_pull_converter: HerrenbergPullConverter):
herrenberg_pull_converter.get_realtime_parking_sites(herrenberg_pull_converter)

0 comments on commit eebc042

Please sign in to comment.