Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test races #57

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Fix test races #57

merged 3 commits into from
Feb 16, 2022

Conversation

iwittkau
Copy link
Contributor

Closes #56

Fixes:

  • possible data races during test execution
  • service multistart detection during test

@iwittkau
Refactor multistart detection
b5d5460 
Multistart detection previously used panics and a global var
to try to detect multistarts during tests.
We are now calling Unlock() on an unlocked mutex to trigger a fatal runtime
error, which is impossible to recover in supervisors.
@iwittkau
Fix test data races
864df00
@iwittkau
Run tests in parallel
a170142
@thejerf thejerf merged commit 511b0e3 into thejerf:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests fail with race detector enabled
2 participants
@iwittkau @thejerf