Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code/tests to apply almost rubocop rules #60

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Refactor code/tests to apply almost rubocop rules #60

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a5ee9ae
Change travis configuration to test on jRuby
nthachus Nov 13, 2019
6cb9359
Use gemspec file to manage dependencies
nthachus Nov 13, 2019
53da296
Use editor configuration file to maintain consistent coding styles
nthachus Nov 13, 2019
8e2e3af
Add development guide into README file
nthachus Nov 13, 2019
f75de16
Update git-ignore file to ignore `vendor/bundle` path
nthachus Nov 13, 2019
c973d17
- Move class `LdapFluff` to the root of Gem lib-path
nthachus Nov 13, 2019
8304926
Update `rubocop` configuration file to use almost rules
nthachus Nov 13, 2019
6584b5a
Move `ldap_test_helper` to the test root as a unit-test entrypoint
nthachus Nov 13, 2019
7fac992
- Reformat all source-code and unit-tests
nthachus Nov 13, 2019
6deecd2
Rename method `is_in_groups?` to `user_in_groups?` by `rubocop` recom…
nthachus Nov 13, 2019
6c37f38
- Refactor all source-code to apply almost `rubocop` rules
nthachus Nov 14, 2019
6d30c6f
- Use base method `*_filter` to create `Net::LDAP::Filter`
nthachus Nov 16, 2019
0e20d70
Make `Config` properties become changeable
nthachus Nov 17, 2019
076d650
- Add `bind_dn_format` config to authenticate with LDAP using bind_dn…
nthachus Nov 19, 2019
8eb7ac3
- Remove deprecated methods (unused anywhere)
nthachus Nov 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use gemspec file to manage dependencies
  • Loading branch information
@nthachus
nthachus committed Nov 13, 2019
commit 6cb9359b5a05ee75a8c2f5720db171a889d32636
13 changes: 2 additions & 11 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,6 @@
# vim:ft=ruby
# frozen_string_literal: true

source 'https://rubygems.org'

if RUBY_VERSION.start_with? '1.9'
gem 'net-ldap', '< 0.13'
end

unless RUBY_VERSION >= '2.2'
gem 'activesupport', '< 5'
end

# Specify gem's dependencies in the gemspec file
gemspec

gem 'rubocop', :group => :test if RUBY_VERSION >= '2.0'
33 changes: 20 additions & 13 deletions ldap_fluff.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,31 @@
# frozen_string_literal: true

Gem::Specification.new do |s|
s.name = 'ldap_fluff'
s.version = '0.4.7'
s.version = '0.5.0'
s.summary = 'LDAP querying tools for Active Directory, FreeIPA and POSIX-style'
s.description = 'Simple library for binding & group querying on top of various LDAP implementations'
s.homepage = 'https://github.com/theforeman/ldap_fluff'
s.license = 'GPLv2'
s.files = Dir['lib/**/*.rb'] + Dir['test/**/*.rb'] + ['README.rdoc', 'LICENSE']
s.extra_rdoc_files = ['README.rdoc', 'LICENSE']

s.require_path = 'lib'
s.test_files = Dir['test/**/*.rb']
s.extra_rdoc_files = %w[README.rdoc LICENSE]
s.files = s.extra_rdoc_files + Dir['lib/**/*.rb']

s.require_paths = ['lib']
s.test_files = Dir['test/**/*.rb']

s.authors = ['Jordan O\'Mara', 'Daniel Lobato', 'Petr Chalupa', 'Adam Price', 'Marek Hulan', 'Dominic Cleal']
s.email = %w[[email protected] [email protected] [email protected] [email protected] [email protected]
[email protected]]

s.required_ruby_version = '>= 1.9.3'

s.has_rdoc = true
s.author = ['Jordan O\'Mara', 'Daniel Lobato', 'Petr Chalupa', 'Adam Price', 'Marek Hulan', 'Dominic Cleal']
s.email = %w([email protected] [email protected] [email protected] [email protected] [email protected] [email protected])
s.add_dependency 'net-ldap', '~> 0.12'
s.add_dependency 'activesupport'

s.required_ruby_version = ">= 1.9.3"
s.add_development_dependency 'bundler', '>= 1.14'
s.add_development_dependency 'rake', '>= 10.0'

s.add_dependency('net-ldap', '>= 0.3.1')
s.add_dependency('activesupport')
s.add_development_dependency('rake')
s.add_development_dependency('minitest')
s.add_development_dependency 'minitest', '~> 5.0'
s.add_development_dependency 'rubocop'
end