Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #52: add six to pip install #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mariojmdavid
Copy link

seems we need to pip install also six

@thefinn93
Copy link
Owner

What environment are you needing this in? Does it break other existing environments? I'd rather not go installing/upgrading any more global packages than I absolutely have to

@mariojmdavid
Copy link
Author

hi, I agree with you but here is what happened,
the ansible client host is a VM with centos7 (from the official centos7 cloud image) with updates plus the following packages
epel-release, ansible git wget python-pip net-tools bind-utils openssl-devel gcc python-devel

after that I pulled the ansible role to my desktop, and run the playbook in issue#52, and obtained the error exception there
as I said I solved the issue by adding six to the task of pip in the role, didn't dig much more at that time
and the task should run in the python virtualenv for the letsencrypt, after this running the playbook went fine.

what I think should have happened would be that when the pip task installs/upgrades setuptools it should have installed six in that virtualenv because setuptools depends on it
(this I just confirmed in a bare centos7 docker - install python-pip and after doing pip install -U setuptools,
before six was not in the pip list, and after it was properly from that dep)

anyway I will check again in another VM,
best
Mario

@mariojmdavid
Copy link
Author

hi
I tested again using a centos7 VM, just with updates and epel-release
the first time I run the playbook, it fails in the issue#52, but running a second time it goes until the end
not too nice but not impeditive,
and since my test of adding "six" I was running the playbook a second time it's possible it does not solve the issue after all
feel free to discard this pull request
maybe be worth a second look so the playbook runs good at first run
best
Mario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants