Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add william.thedev.id #561

Merged
merged 1 commit into from
Dec 17, 2022
Merged

add william.thedev.id #561

merged 1 commit into from
Dec 17, 2022

Conversation

wdhdev
Copy link
Contributor

@wdhdev wdhdev commented Dec 16, 2022

No description provided.

@wdhdev
Copy link
Contributor Author

wdhdev commented Dec 16, 2022

You'll need to add the record to the zone file first to set-up https.

@lakuapik
Copy link
Member

@WilliamDavidHarrison will this still a redirect or not?

#506

@lakuapik lakuapik added the need-verification Site need to be verified before adding to CNAME records label Dec 16, 2022
@wdhdev
Copy link
Contributor Author

wdhdev commented Dec 16, 2022

@WilliamDavidHarrison will this still a redirect or not?

#506

No, I'm putting a code server on it

@lakuapik lakuapik added the cname-added CNAME for subdomain already created. label Dec 16, 2022
@lakuapik
Copy link
Member

@WilliamDavidHarrison i've added the CNAME, please check on your side.

@wdhdev
Copy link
Contributor Author

wdhdev commented Dec 16, 2022

@WilliamDavidHarrison i've added the CNAME, please check on your side.

I've generated an SSL. It should work now.

@lakuapik
Copy link
Member

Is this what it supposed to be displayed? a code server? not a personal/portfolio/project/blog website?

image

@wdhdev
Copy link
Contributor Author

wdhdev commented Dec 16, 2022

Is this what it supposed to be displayed? a code server? not a personal/portfolio/project/blog website?

image

Yes. It's Visual Studio Code on the web.

@lakuapik
Copy link
Member

i see. unfornately, a personal tool is not allowed to have thedev.id domain. our requirements is: the site must be in one of these types:

  • a personal website
  • a portfolio website
  • a blog website
  • a project website

and must be public with enough content for verification.

@WilliamDavidHarrison do you have a plan to switch the domain with new website? if not i will remove the cname and close this PR.

@wdhdev
Copy link
Contributor Author

wdhdev commented Dec 16, 2022

i see. unfornately, a personal tool is not allowed to have thedev.id domain. our requirements is: the site must be in one of these types:

  • a personal website
  • a portfolio website
  • a blog website
  • a project website

and must be public with enough content for verification.

@WilliamDavidHarrison do you have a plan to switch the domain with new website? if not i will remove the cname and close this PR.

If you wanted I could copy my current dev website and put it on there: https://wdh.gg/dev

@lakuapik
Copy link
Member

@WilliamDavidHarrison its up to you. as long as the requested domain has content that meet our requirements.

@wdhdev
Copy link
Contributor Author

wdhdev commented Dec 16, 2022

@WilliamDavidHarrison its up to you. as long as the requested domain has content that meet our requirements.

Done

@lakuapik
Copy link
Member

the site is now accessible with thedev.id domain:

image

@lakuapik lakuapik added site-verified Site can be accessed and verified by thedev.id team subdomain-active Subdomain is assigned, active and the site is up. and removed need-verification Site need to be verified before adding to CNAME records labels Dec 17, 2022
@lakuapik lakuapik merged commit 407aa55 into thedev-id:main Dec 17, 2022
@wdhdev wdhdev deleted the patch-1 branch December 17, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cname-added CNAME for subdomain already created. site-verified Site can be accessed and verified by thedev.id team subdomain-active Subdomain is assigned, active and the site is up.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wdhdev @lakuapik