Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo #454

Merged
merged 1 commit into from
Aug 11, 2021
Merged

fixed typo #454

merged 1 commit into from
Aug 11, 2021

Conversation

schbz
Copy link
Contributor

@schbz schbz commented Jul 17, 2021

changed "rich restults test" to "rich results test"

Fixes: #

🚨 Please review the guidelines for contributing and our code of conduct to this repository. 🚨
Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:

  • [ x] Check the commit's or even all commits' message styles matches our requested structure.
  • [ x] Check your code additions will fail neither code linting checks nor unit test.

Short description of what this resolves:

the word "results" was misspelled.

Proposed changes:

just a simple typo correction. Everything else looks perfect.

👍 Thank you!

changed "rich restults test" to "rich results test"
@PhantomRex123
Copy link

no one cares about a typo :) Thanks

@schbz
Copy link
Contributor Author

schbz commented Jul 18, 2021

no one cares about a typo :) Thanks

True, I've got to start somewhere though, lol

@PhantomRex123
Copy link

no one cares about a typo :) Thanks

True, I've got to start somewhere though, lol

You start by helping people, not fixing a typo. Btw if your reading this you prob read typo's like they are correct. Sad to see people get credit for fixing a typo.

@schbz
Copy link
Contributor Author

schbz commented Jul 18, 2021

there's a big dif between typos and abbrv. if you don't want to give me credit then don't. I was just experimenting with the pull request system.

@PhantomRex123
Copy link

Experiment on your own repo's.

@PhantomRex123
Copy link

I'm not trying to be rude.
I'm just saying "Stop opening a pull for a simple typo"
That's all.

Regards,
Stay safe,
Ryan s.

@schbz
Copy link
Contributor Author

schbz commented Jul 18, 2021

message received. Now I know. have a nice day.

@schbz schbz closed this Jul 18, 2021
@PhantomRex123
Copy link

message received. Now I know. have a nice day.

sorry to be a pain in the ass. Just tryin to remove bad habits with people fixing typo's in like every repository

@schbz
Copy link
Contributor Author

schbz commented Jul 18, 2021

message received. Now I know. have a nice day.

sorry to be a pain in the ass. Just tryin to remove bad habits with people fixing typo's in like every repository

No worries. I wouldn't want people spamming my repos either. For future reference, is it a good idea to open an issue to notify people of things like spelling mistakes instead, or is it more polite to just completely ignore them?

@clovergaze
Copy link

Seriously, if you want to improve something, go ahead and do as you please. I like reading stuff without typos in it.

@PhantomRex123
Copy link

message received. Now I know. have a nice day.

sorry to be a pain in the ass. Just tryin to remove bad habits with people fixing typo's in like every repository

No worries. I wouldn't want people spamming my repos either. For future reference, is it a good idea to open an issue to notify people of things like spelling mistakes instead, or is it more polite to just completely ignore them?

i rlly would say you can ignore them. But i dont know why you closed this pull. I didn't tell you to remove it i just told you that it can be quite annoying :)

i'd be happy if you re-opened this

@schbz
Copy link
Contributor Author

schbz commented Jul 18, 2021

Ok cool thanks.

@schbz schbz reopened this Jul 18, 2021
@thedaviddias
Copy link
Owner

Ok cool thanks.

I'm sorry @schbz to have not seen this conversation before, any contribution is valuable, thanks for fixing an issue even it's just a typo issue.

@9ebd7134 we have rules on Github and on this repo, respect is one of the rule, please avoid discouraging newcomers just trying to enter in the world of open-source. Anyone can starts with what they feel confortable.

@thedaviddias thedaviddias merged commit 6e709a3 into thedaviddias:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants