Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sawnsprojects/krush60_solder #2171

Merged
merged 6 commits into from
Jul 14, 2024
Merged

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Feb 20, 2024

Description

  1. "7u HHKB" (bottom row) option missing 1u keys at each side. Minor correction to add missing keys.
  2. Fix key colours for right shift options

QMK Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22
Copy link
Collaborator

Xelus22 commented Feb 25, 2024

Only V2? is there no V3?

@dunk2k
Copy link
Contributor Author

dunk2k commented Feb 25, 2024

Only V2? is there no V3?

Unintended oversight, I'll get to fixing that. Thanks for checking 🙂

@dunk2k dunk2k changed the title Fix "7u HHKB" for sawnsprojects/krush60_solder Fix sawnsprojects/krush60_solder Jul 8, 2024
@Xelus22 Xelus22 merged commit d5607c8 into the-via:master Jul 14, 2024
2 checks passed
@dunk2k dunk2k deleted the krush60s_fix branch July 14, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants