Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LINE FRIENDS TKL #2078

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

studiokestra
Copy link
Contributor

Description

Add VIA support for LINE FRIENDS TKL PCB.

QMK Pull Request

qmk/qmk_firmware#22172

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3/studiokestra/line_friends_tkl/line_friends_tkl.json

Please use the same tree naming as QMK without the word friends

@studiokestra
Copy link
Contributor Author

studiokestra commented Nov 20, 2023

@Xelus22 I should have mentioned that the vendor requested the PCB be renamed to LINE FRIENDS TKL to comply with their branding guideline. The QMK PR for the rename was completed and merged here: qmk/qmk_firmware#22310

Sorry for any confusion

@Xelus22
Copy link
Collaborator

Xelus22 commented Nov 20, 2023

@studiokestra thanks. Will have to wait for the develop->master merge.
https://docs.qmk.fm/#/breaking_changes?id=when-is-the-next-breaking-change

Next one is 26th November (in 6 days). Ping me if I forget to check this again. Thanks :)

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for develop->master merge... 26th nov

@Xelus22 Xelus22 merged commit 0036e7a into the-via:master Dec 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants