Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TKC Portico75 to support Encoder Map #1990

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

Jpe230
Copy link
Contributor

@Jpe230 Jpe230 commented Aug 16, 2023

Description

The current definition doesn't support correctly the encoder, I've updated the definition to enable the mapping of the encoder.

QMK Pull Request

The keyboard was already in QMK's repo, but the encoder map feature was added in December of 2022 and the definition for VIA wasn't update ever since.

qmk/qmk_firmware#19359

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22 Xelus22 merged commit a63438b into the-via:master Aug 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants