Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lighting UI options for GMMK 2 #1607

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Update lighting UI options for GMMK 2 #1607

merged 1 commit into from
Jan 3, 2023

Conversation

adophoxia
Copy link
Contributor

Description

Change qmk_rgblight in ["menus"]to qmk_rgb_matrix as GMMK 2 uses RGB_MATRIX lighting due to people noticing that the Lighting tab is disabled (as in it doesn't show the options to change effects and effect speed/color/brightness.)

image

QMK Pull Request

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@adophoxia
Update lighting UI options for GMMK 2
23e5e34 
Change `qmk_rgblight` to `qmk_rgb_matrix` as GMMK 2 uses `RGB_MATRIX` lighting.
@yiancar
Copy link
Collaborator

yiancar commented Jan 3, 2023

Cheers thanks!

@yiancar yiancar merged commit ae26c52 into the-via:master Jan 3, 2023
@adophoxia adophoxia deleted the gmmk2-rgb-matrix branch January 4, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adophoxia @yiancar