Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add Quarkeys Z60 Solder Via file V3 #1602

Closed
wants to merge 6 commits into from

Conversation

tommyamoszhao
Copy link
Contributor

@tommyamoszhao tommyamoszhao commented Dec 22, 2022

Description

QMK Pull Request

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@tommyamoszhao
Copy link
Contributor Author

Just submitted firmware file to QMK master repository & verified, tested Z60-SD_VIA.json in online VIA already, works perfect. V2 json file seems to have conflict with latest qmk firmware, still trying to have it work. So upload the V3 json file for via first.

@yiancar
Copy link
Collaborator

yiancar commented Jan 3, 2023

Hello, Can you please provide the link to the QMK files or the PR request to QMK?

@tommyamoszhao
Copy link
Contributor Author

Hi yiancar, yes sure. https://github.com/qmk/qmk_firmware/tree/master/keyboards/quarkeys/z60
Z60 has already been merged. link above. I added v2 json for solder and hotswap. please notice.
PS, first time doing PR on VIA side, so if there's any routine I need to follow, please let me know, appreciate

@tommyamoszhao
Copy link
Contributor Author

Z67 has PRed, all checks passed, awaits to be merged. Here's the link:
qmk/qmk_firmware#19465
Thank you so much.

@yiancar
Copy link
Collaborator

yiancar commented Jan 3, 2023

Hello There usually we expect a PR to be opened after the QMK PR has been merged.
Typically we would close it and reopen it then but lets allow it this time round:)
Please ping me with a comment once the PR on QMK side has been merged.

@yiancar yiancar added the blocked label Jan 3, 2023
@tommyamoszhao
Copy link
Contributor Author

Hello There usually we expect a PR to be opened after the QMK PR has been merged. Typically we would close it and reopen it then but lets allow it this time round:) Please ping me with a comment once the PR on QMK side has been merged.
Hi yiancar, thank you so much, I'll request a PR after relative firmware is merged next time. I'll keep an eye on the latest keyboard on qmk side, and comment here once it's merged. Cheers, TommyZ

@yiancar
Copy link
Collaborator

yiancar commented Jan 19, 2023

@tommyamoszhao looks like QMK requested some changes from you..

@yiancar
Copy link
Collaborator

yiancar commented Jan 26, 2023

Ok I will be closing this as its been almost a month and no update. Please feel free to ping me once qmk is checked in.

@yiancar yiancar closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants