Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullbits SNAP keyboard #1506

Merged
merged 2 commits into from
Apr 8, 2023
Merged

Conversation

jaygreco
Copy link
Contributor

@jaygreco jaygreco commented Oct 31, 2022

Description

Add the nullbits SNAP keyboard.

QMK Pull Request

qmk/qmk_firmware#18916

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22 Xelus22 added the pending QMK merge Waiting for merge into QMK master label Nov 4, 2022
@yiancar
Copy link
Collaborator

yiancar commented Dec 6, 2022

To keep the PR requests clean, we will close this request for now. Please leave a comment when QMK has been merged and we will open it again:)

@yiancar yiancar closed this Dec 6, 2022
@jaygreco
Copy link
Contributor Author

jaygreco commented Apr 2, 2023

Hi @yiancar! The QMK PR (#18916) was FINALLY merged. Do you mind opening this again? Do you know if there have been any breaking changes to the VIA schema in the few months that have passed that I'll need to address?

@yiancar yiancar reopened this Apr 2, 2023
@yiancar
Copy link
Collaborator

yiancar commented Apr 2, 2023

Hello, Yes you will need to create a v3 json as well. please check the docs:)

@jaygreco
Copy link
Contributor Author

jaygreco commented Apr 2, 2023

Hello, Yes you will need to create a v3 json as well. please check the docs:)

Thanks for the heads up @yiancar. Done!

@jaygreco
Copy link
Contributor Author

jaygreco commented Apr 7, 2023

Hi @yiancar, can this be merged? Thanks, and apologies for the ping.

@Xelus22 Xelus22 merged commit 7c50ad2 into the-via:master Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending QMK merge Waiting for merge into QMK master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants