Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sinc Rev. 3 and Update Rev 1-2 #1499

Merged
merged 5 commits into from
Nov 4, 2022
Merged

Conversation

nooges
Copy link
Contributor

@nooges nooges commented Oct 26, 2022

Description

  • Add Sinc Rev. 3
  • Add support for encoder mapping to Sinc Rev. 1 and 2

QMK Pull Request

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@nooges nooges marked this pull request as ready for review October 31, 2022 12:47
@Xelus22
Copy link
Collaborator

Xelus22 commented Nov 4, 2022

LGTM. Thanks!

@Xelus22 Xelus22 merged commit bd26451 into the-via:master Nov 4, 2022
@nooges nooges deleted the sinc-rev3 branch December 9, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants