Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and update GMMK 2 JSONs #1471

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Add and update GMMK 2 JSONs #1471

merged 2 commits into from
Oct 14, 2022

Conversation

adophoxia
Copy link
Contributor

@adophoxia adophoxia commented Oct 9, 2022 •
edited
Loading

Description

  • Add VIA JSONs for ANSI and ISO variants of GMMK 2 p65
  • Add VIA JSON for ISO variant of GMMK 2 p96
  • Update JSON for ANSI variant of GMMK 2 p96 to account for ISO addition

QMK Pull Request

qmk/qmk_firmware#16436 (p96)
qmk/qmk_firmware#18185 (p65)

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@adophoxia
Add and update GMMK 2 JSONs
c98f5d8 
- Add VIA JSONs for ANSI and ISO variants of GMMK 2 p65.
- Add VIA JSON for ISO variant of GMMK 2 p96
- Update JSON for ANSI variant of GMMK 2 p96 to account for ISO addition
@Xelus22
Copy link
Collaborator

Xelus22 commented Oct 10, 2022

Please link the accompanying QMK PR.

@Xelus22 Xelus22 added the pending QMK merge Waiting for merge into QMK master label Oct 10, 2022
@adophoxia
Copy link
Contributor Author

Updated to include the following PRs.

@Xelus22
Copy link
Collaborator

Xelus22 commented Oct 14, 2022

LGTM. Thanks!

@Xelus22 Xelus22 merged commit 0562db5 into the-via:master Oct 14, 2022
@adophoxia adophoxia deleted the gmmk-2-update-addition branch October 14, 2022 13:22
@the-ashh the-ashh mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending QMK merge Waiting for merge into QMK master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adophoxia @Xelus22