[CHORE] adding auto GOMEMLIMIT flag #7223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolastakashi
force-pushed
the
chore/adding-go-memlimit
branch
2 times, most recently
from
b0631e6
to
9ae4c45
Compare
GiedriusS
reviewed
Mar 21, 2024
GiedriusS
previously approved these changes
Mar 22, 2024
nicolastakashi
force-pushed
the
chore/adding-go-memlimit
branch
from
9ae4c45
to
93f59ff
Compare
nicolastakashi
force-pushed
the
chore/adding-go-memlimit
branch
2 times, most recently
from
3db9990
to
562e3ba
Compare
|
@GiedriusS could you review again? |
I'll rerun it |
fpetkovski
reviewed
Mar 23, 2024
nicolastakashi
force-pushed
the
chore/adding-go-memlimit
branch
3 times, most recently
from
4abd8b4
to
2234eb3
Compare
nicolastakashi
force-pushed
the
chore/adding-go-memlimit
branch
2 times, most recently
from
5ef4d8e
to
474eb94
Compare
nicolastakashi
force-pushed
the
chore/adding-go-memlimit
branch
2 times, most recently
from
fe7c2f0
to
f580b40
Compare
nicolastakashi
force-pushed
the
chore/adding-go-memlimit
branch
from
f580b40
to
fe1b2f7
Compare
MichaHoffmann
previously approved these changes
Mar 23, 2024
nicolastakashi
force-pushed
the
chore/adding-go-memlimit
branch
from
fe1b2f7
to
9bc3586
Compare
nicolastakashi
force-pushed
the
chore/adding-go-memlimit
branch
from
9bc3586
to
bec0afe
Compare
nicolastakashi
force-pushed
the
chore/adding-go-memlimit
branch
from
bec0afe
to
ef98c6f
Compare
fpetkovski
approved these changes
Mar 23, 2024
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Apr 4, 2024
Co-authored-by: Filip Petkovski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding a flag to automatically configure GOMEMLIMIT.
Verification
Setting Resource Limits on Kubernetes.