receive: implement without replica labels capability #6143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add without replica labels capability to Thanos Receive. Internally, we are already advertising that local TSDB client supports without replica labels. This wires the last pieces. Signed-off-by: Giedrius Statkevičius <[email protected]>
56fcc47
to
5245a89
Compare
|
Should we flip the flag for the ruler too? I think it uses the same TSDB store. |
I think let's do it in a separate PR, perhaps it will need some extra changes 😄 |
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
Add without replica labels capability to Thanos Receive. Internally, we are already advertising that local TSDB client supports without replica labels. This wires the last pieces. Signed-off-by: Giedrius Statkevičius <[email protected]>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
Add without replica labels capability to Thanos Receive. Internally, we are already advertising that local TSDB client supports without replica labels. This wires the last pieces. Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add without replica labels capability to Thanos Receive. Internally, we are already advertising that local TSDB client supports without replica labels. This wires the last pieces.