Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated readme link to prepend tip to fix Page Not Found; Disabled Liche temporarily. #3067

Merged
merged 5 commits into from
Aug 26, 2020
Merged

Updated readme link to prepend tip to fix Page Not Found; Disabled Liche temporarily. #3067

merged 5 commits into from
Aug 26, 2020

Conversation

mllu
Copy link
Contributor

@mllu mllu commented Aug 25, 2020 •
edited
Loading

  • I added CHANGELOG entry for this change. (not sure which section to put under Fixed or Changed?)
  • Change is not relevant to the end user.

Changes

trying to fix the incorrect readme links that showing Page Not Found which were changed by this PR https://github.com/thanos-io/thanos/pull/2802/files#diff-6b3df26d750e09528185b365bbd99a76R72-R77 as shown below

Screen Shot 2020-08-24 at 10 18 05 PM

Verification

click links from github readme

bwplotka
bwplotka approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bwplotka
Copy link
Member

CI is still failing though, do you mind running make docs and committing changes
?

@bwplotka
Copy link
Member

I will do that for you if you don't mind (:

@bwplotka
Updated liche.
ef2e8b3 
Signed-off-by: Bartlomiej Plotka <[email protected]>
@bwplotka
Fixed docs.
4d4ef38 
Signed-off-by: Bartlomiej Plotka <[email protected]>
@mllu
Copy link
Contributor Author

mllu commented Aug 25, 2020

Ahh, thx, please help me, make docs acting weird to me, it delete t character at the end of each word.

@mllu
Copy link
Contributor Author

mllu commented Aug 25, 2020

@bwplotka do you by any chance know what happen for failed CI checks? seems besides docs one, linter and end-to-end tests also failed.

@bwplotka
Copy link
Member

Yea I am on it - unlucky day for CI ;p

@bwplotka
Added more info to makefile.
d2070c1 
Signed-off-by: Bartlomiej Plotka <[email protected]>
@bwplotka
Fixed more links.
c2f13c2 
Signed-off-by: Bartlomiej Plotka <[email protected]>
@bwplotka bwplotka mentioned this pull request Aug 25, 2020
Closed
@bwplotka bwplotka changed the title update readme link to prepend tip to fix Page Not Found Updated readme link to prepend tip to fix Page Not Found; Disabled Liche temporarily. Aug 25, 2020
@bwplotka
Copy link
Member

Ok let's disable Liche we need long term fix now :/ Let's do this in separate PR and merge this on green. At least README links will be working

@mllu
Copy link
Contributor Author

mllu commented Aug 26, 2020 •
edited
Loading

hope google will crawl the latest webpages and update pagerank soon since they still linked to the old ones

@bwplotka bwplotka merged commit e9a9753 into thanos-io:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mllu @bwplotka