Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate changelog #2998

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Conversation

mneverov
Copy link
Contributor

@mneverov mneverov commented Aug 7, 2020

Signed-off-by: Max Neverov [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Deduplicate changelog. Fixes: #2856

Verification

I used the following command to find duplicates:

awk '/\[.?[0-9]+\]/ {print $2}' CHANGELOG.md | sort | uniq -d

[#1362](https://github.com/thanos-io/thanos/pull/1362)
[#1770](https://github.com/thanos-io/thanos/pull/1770)
[#1838](https://github.com/thanos-io/thanos/pull/1838)
[#2166](https://github.com/thanos-io/thanos/pull/2166)
[#2526](https://github.com/thanos-io/thanos/pull/2526)
[2603](https://github.com/thanos-io/thanos/pull/2603)
[#2667](https://github.com/thanos-io/thanos/pull/2667)
[#2671](https://github.com/thanos-io/thanos/pull/2671)
[#2705](https://github.com/thanos-io/thanos/pull/2705)

Most of these PRs are mentioned both in Added and Changed, except 2166, 2603, 2705

Signed-off-by: Max Neverov <[email protected]>
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution. LGTM.

@bwplotka
Copy link
Member

bwplotka commented Aug 7, 2020

It would awesome to make script for this to validate for duplicates.. Or TBH just some tooling for changelog really overall 🤔

@bwplotka bwplotka merged commit 0d033bf into thanos-io:master Aug 7, 2020
@bwplotka
Copy link
Member

bwplotka commented Aug 7, 2020

Something like this: #2999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix duplicated entries for v0.13.0 in CHANGELOG
3 participants