Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes: #2986
Changes in
quickstart.sh
:MINIO_ENABLED
is disabled by defaultS3_ENDPOINT
is empty by default and filled in only when minio is enabled, hence thanos does not run storeOBJSTORECFG
, andSTORES
)I didn't add anything to the changelog, since the last ~10 commits to the quickstart.sh are not reflected there.
Verification
Verified manually by running
PROMETHEUS_EXECUTABLE=~/go/src/github.com/prometheus/prometheus/prometheus THANOS_EXECUTABLE=~/go/bin/thanos MINIO_ENABLED="" ./scripts/quickstart.sh
.log is attached.
log.txt
Note, that there are still errors
level=error name=query-0 ts=2020-08-05T13:14:02.164403579Z caller=logger.go:22 msg="failed to flush Jaeger spans to server: write udp 127.0.0.1:54187->127.0.0.1:6831: write: connection refused"
, that might need investigation