Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quickstart #2988

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Fix quickstart #2988

merged 1 commit into from
Aug 6, 2020

Conversation

mneverov
Copy link
Contributor

@mneverov mneverov commented Aug 5, 2020

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes: #2986

Changes in quickstart.sh:

  • MINIO_ENABLED is disabled by default
  • S3_ENDPOINT is empty by default and filled in only when minio is enabled, hence thanos does not run store
  • thanos arguments are parsed correctly (no empty arguments OBJSTORECFG, and STORES)
  • thanos arguments are dumped in console on parse error. NOTE please object if you think it might be a security issue - i'll remove it

I didn't add anything to the changelog, since the last ~10 commits to the quickstart.sh are not reflected there.

Verification

Verified manually by running PROMETHEUS_EXECUTABLE=~/go/src/github.com/prometheus/prometheus/prometheus THANOS_EXECUTABLE=~/go/bin/thanos MINIO_ENABLED="" ./scripts/quickstart.sh.

log is attached.
log.txt

Note, that there are still errors level=error name=query-0 ts=2020-08-05T13:14:02.164403579Z caller=logger.go:22 msg="failed to flush Jaeger spans to server: write udp 127.0.0.1:54187->127.0.0.1:6831: write: connection refused", that might need investigation

@GiedriusS
Copy link
Member

Maybe @kakkoyun you could help out in reviewing this? 🤗

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Awesome that you have caught this, thanks a lot.
This is mostly my misinterpretation of linter warnings in #2969.
Tried and works as expected.

@kakkoyun kakkoyun merged commit 758d848 into thanos-io:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected errors in quickstart.sh
3 participants