Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Remove Jsonnet ci container #2963

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Makefile: Remove Jsonnet ci container #2963

merged 1 commit into from
Jul 30, 2020

Conversation

kakkoyun
Copy link
Member

With the use of Bingo, we don't need to maintain these actions. So I'm removing them.

  • Change is not relevant to the end-user.

Changes

  • Remove unnecessary Make actions

@kakkoyun kakkoyun requested review from bwplotka and yeya24 July 30, 2020 14:59
yeya24
yeya24 approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bwplotka
bwplotka approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bwplotka bwplotka merged commit 2565a7c into thanos-io:master Jul 30, 2020
@kakkoyun kakkoyun deleted the remove_jsonnet_ci_container branch July 30, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kakkoyun @bwplotka @yeya24