Upgraded tools; Split of CI jobs into pieces; Moved some to GH actions; different way of managing tools. #2670
Conversation
3adbfd8
to
cc1daea
Compare
|
This should be ready for review 🤗 Finally after a day of fighting with this. Now most of the things are split, plus golint no longer OOMs (upgrade + move to GH actions) I also used my https://github.com/bwplotka/bingo project for binary management. This however is not needed for USAGE of those binaries, just for managing them. I will write small blog post about it. |
c7b8345
to
43ff0db
Compare
|
It works, looks like just newest |
…s; different way of managing tools. Signed-off-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>
|
Green! |
| # @echo "Running alertmanager" | ||
| # @$(ALERTMANAGER) <flags/args..> | ||
| # | ||
| ALERTMANAGER ?= $(GOBIN)/alertmanager-v0.20.0 |
There was a problem hiding this comment.
For each binary, the version is repeated 3 times. Have you considered adding a ALERMANAGER_VERSION variable and then using it, similarly to what we did in Makefile before?
There was a problem hiding this comment.
Since this is a generated file, I don't think it's too bad, but agreed.
There was a problem hiding this comment.
No need for this, https://github.com/bwplotka/bingo recreates this file anyway (:
| tags: | ||
| pull_request: | ||
|
|
||
| # TODO(bwplotka): Add tests here. |
There was a problem hiding this comment.
e2e tests or unit tests? The first one has been done.
There was a problem hiding this comment.
Unit tests (:
They are still in the Circle CI for now.
| run: make format | ||
|
|
||
| - name: Linting & vetting. | ||
| run: make go-lint |
There was a problem hiding this comment.
Note to myself: before we were calling make lint which calls go-lint and react-app-lint targets. Now, calling only go-lint, we've lost react-app-lint, but react-app-lint is called by react-app-test in the react workflow, so all good.
| # @echo "Running alertmanager" | ||
| # @$(ALERTMANAGER) <flags/args..> | ||
| # | ||
| ALERTMANAGER ?= $(GOBIN)/alertmanager-v0.20.0 |
There was a problem hiding this comment.
Since this is a generated file, I don't think it's too bad, but agreed.
|
Gonna go ahead and merge this, to make CI work on master again. |
…s; different way of managing tools. (thanos-io#2670) * Upgraded tools; Split of CI jobs into pieces; Moved some to GH actions; different way of managing tools. Signed-off-by: Bartlomiej Plotka <[email protected]> * Trying separate action for docs once again. Signed-off-by: Bartlomiej Plotka <[email protected]> * Reverted jb version. Signed-off-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Bartlomiej Plotka [email protected]
Fixes: #2663