Make the log formatter configurable #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change lets us configure the deamon and the plugins to output logs in the JSON format, which is easier to parse/filter by log processing tools.
tg123
reviewed
May 7, 2024
|
everything looked good to me, let me fix the pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for not opening a feature request first. Just wanted to see how easy it was to implement support for JSON logs and it ended up being fairly simple.
Any chance this could be merged? I'm happy to make adjustments if you see any issues with the current implementation. The main goal is to be able to configure sshpiper to output logs in JSON format (by using
logrus's JSONFormatter instead of the default Text one).